Make attachment_user_provided property_id nullable#8228
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
mikeGarifullin
approved these changes
May 19, 2026
mikeGarifullin
added
the
db-migration
…nal-property-id-upload
… head Both 1e00f8e12f44 and 9f21507db078 had down_revision=9b449105864d, producing two heads and breaking alembic upgrade in CI.
mypy caught that AttachmentUserProvidedRecord.property_id was still 'str' after the column became nullable. Also add missing changelog entry.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8228 +/- ##
=======================================
Coverage 85.64% 85.64%
=======================================
Files 661 661
Lines 42941 42942 +1
Branches 5027 5027
=======================================
+ Hits 36775 36776 +1
Misses 5063 5063
Partials 1103 1103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
property_idcolumn onattachment_user_providedtonullable=Truecreate_uploaded()repository method to acceptOptional[str]Supports deployments that don't use properties by allowing file uploads without a property context.
Test plan
alembic upgrade head)alembic downgrade -1)