Add Stewardship tab to user detail page#8240
Merged
Merged
Conversation
Read-only tab on the user profile page that lists the systems and
monitors the user is assigned as a steward of. Uses the existing
/user/{id}/system-manager and /user/{id}/monitor endpoints; no
backend changes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Addresses prototype feedback: surface a doc link explaining how to update a steward's monitor assignments, since this tab itself is read-only. The docs page does not exist yet, so the URL is a placeholder marked with a TODO and will be swapped once published. Also adds a changelog entry for the new tab. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Use RouterLink (Typography.Link-styled, prefetching) instead of bare
NextLink for in-app navigation in both Systems and Monitors tables.
- Build URLs from EDIT_SYSTEM_ROUTE / INTEGRATION_DETAIL_ROUTE constants
via the project-standard `.replace("[id]", value)` pattern, matching
existing call sites.
- Replace `activeUserId as string` casts + skip flag with the idiomatic
RTK Query `skipToken` sentinel, so the query argument types are honest.
- Migrate the top-level layout from Space (deprecated `direction` prop,
per-child wrapper divs) to Flex, the documented vertical-stack primitive.
- Swap the inline `Typography.Link` for the project's DocsLink helper,
which applies `rel="noopener noreferrer"` (addresses tab-nabbing more
correctly than the previous `rel="nofollow"`).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
speaker-ender
approved these changes
May 20, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ethyca.atlassian.net/browse/ENG-3885
https://www.loom.com/share/1a0e2443ab7048ceb5e1bc6819166091
Description Of Changes
Adds a read-only Stewardship tab to the user detail page. The tab surfaces the systems and discovery monitors a given user is assigned as a steward of, so admins can quickly audit a steward's responsibilities from the user profile. Uses the existing
/user/{id}/system-managerand/user/{id}/monitorendpoints — no backend changes.Prototype feedback asked for a link to documentation explaining how to update a steward's monitor assignments (since this tab itself is read-only). That docs page doesn't exist yet, so the URL is currently a placeholder with a
TODOcomment inStewardshipTab.tsxflagging that it should be swapped once the docs are published. This is intentional and shouldn't block design or implementation review.Code Changes
StewardshipTab.tsxcomponent renders two cards (Systems and Monitors) with antd Tables, each linking rows to the respective detail page.UserManagementTabs.tsxregisters the new tab.StewardshipTab.tsxincludes a placeholder documentation link in the Monitors card, gated byMONITOR_STEWARDSHIP_DOCS_URLwith aTODOto update once the docs page exists.changelog/user-stewardship-tab.yaml.Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works🤖 Generated with Claude Code