Skip to content

Fix property form paths not saving and actions during create#8271

Merged
jpople merged 1 commit into
mainfrom
fix-property-form-paths-and-actions
May 27, 2026
Merged

Fix property form paths not saving and actions during create#8271
jpople merged 1 commit into
mainfrom
fix-property-form-paths-and-actions

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented May 22, 2026

Summary

  • Replace custom PathsEditor component with Ant Design Form.List for the property paths field, fixing paths not being included in PUT/POST payloads
  • Hide the "Edit form" link in the actions table when creating a new property (no property ID yet), allowing actions to be added during create and saved with the initial POST

Test plan

  • Create a property with paths — verify paths are included in the POST payload and persist
  • Edit a property — verify existing paths load, new paths can be added, and all paths are in the PUT payload
  • Remove a path before saving — verify only remaining paths are submitted
  • On the create property page, set up privacy center config and add an action — verify the modal works and the action is included in the POST
  • On the edit property page, verify the "Edit form" link appears on actions
  • Run ActionsTable unit tests: all 4 pass
  • Run properties.cy.ts Cypress tests

@jpople jpople requested a review from a team as a code owner May 22, 2026 17:28
@jpople jpople requested review from gilluminate and removed request for a team May 22, 2026 17:28
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment May 22, 2026 5:29pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored May 22, 2026 5:29pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 11%
8.54% (4061/47512) 7.59% (2096/27582) 5.82% (813/13961)
fides-js Coverage: 78%
79.17% (1977/2497) 66.25% (1249/1885) 73.31% (349/476)
privacy-center Coverage: 88%
86.59% (517/597) 82.33% (247/300) 81.08% (90/111)

} from "~/types/api";

import DeletePropertyModal from "./DeletePropertyModal";
import { PathsEditor } from "./PathsEditor";
Copy link
Copy Markdown
Contributor

@gilluminate gilluminate May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be deleted now? Still used anywhere else? It has associated tests, should those be migrated to this now?

@jpople
Copy link
Copy Markdown
Contributor Author

jpople commented May 26, 2026

Closing in favor of a new PR on fidesplus/clients, since the frontend codebase has moved there.

@jpople jpople closed this May 26, 2026
@jpople jpople reopened this May 27, 2026
@jpople jpople enabled auto-merge May 27, 2026 15:14
@jpople jpople added this pull request to the merge queue May 27, 2026
Merged via the queue into main with commit 8864251 May 27, 2026
95 of 97 checks passed
@jpople jpople deleted the fix-property-form-paths-and-actions branch May 27, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants