Skip to content

ENG-3270 Reduce per-request overhead for API throughput#8284

Merged
erosselli merged 2 commits into
mainfrom
erosselli/ENG-3270-current-prefs-fides
Jun 1, 2026
Merged

ENG-3270 Reduce per-request overhead for API throughput#8284
erosselli merged 2 commits into
mainfrom
erosselli/ENG-3270-current-prefs-fides

Conversation

@erosselli
Copy link
Copy Markdown
Contributor

@erosselli erosselli commented Jun 1, 2026 •
edited by atlassian Bot
Loading

Ticket ENG-3270

Description Of Changes

This is being retroactively applied from the combined Fides + Fidesplus repo; this PR applies the Fides-side changes from https://github.com/ethyca/fidesplus/pull/3679.

Steps to Confirm

  1. Look at PR https://github.com/ethyca/fidesplus/pull/3679 and confirm the changes applied here are exactly the same

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@erosselli @claude
ENG-3270: Reduce per-request overhead for API throughput
974790a 
Replace the global Loguru patcher with scoped logger.contextualize() in
the ASGI middleware and Celery task signals. Cache the JWE OctKey via
lru_cache. Move sync calls in async auth and health paths to
run_in_executor.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@erosselli erosselli requested review from a team as code owners June 1, 2026 13:31
@erosselli erosselli requested review from galvana and gilluminate and removed request for a team June 1, 2026 13:31
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jun 1, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Jun 1, 2026 1:37pm
fides-privacy-center Ignored Ignored Jun 1, 2026 1:37pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026 •
edited
Loading

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
See the Details below.

Scanned Files

  • clients/admin-ui/package.json
  • clients/package-lock.json
  • docs/fides/requirements.txt
  • qa/requirements.txt

@erosselli erosselli closed this Jun 1, 2026
@erosselli erosselli reopened this Jun 1, 2026
@erosselli erosselli changed the base branch from release-2.86.2 to main June 1, 2026 13:32
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.09%. Comparing base (d85fa4a) to head (494f904).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8284   +/-   ##
=======================================
  Coverage   85.09%   85.09%           
=======================================
  Files         669      669           
  Lines       43591    43603   +12     
  Branches     5127     5127           
=======================================
+ Hits        37095    37106   +11     
- Misses       5391     5392    +1     
  Partials     1105     1105

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erosselli erosselli added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit e87f3ff Jun 1, 2026
68 of 69 checks passed
@erosselli erosselli deleted the erosselli/ENG-3270-current-prefs-fides branch June 1, 2026 14:08
erosselli added a commit that referenced this pull request Jun 1, 2026
@erosselli @claude
ENG-3270 Reduce per-request overhead for API throughput (#8284)
d3eb43b 
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsachs adamsachs adamsachs approved these changes

@galvana galvana Awaiting requested review from galvana galvana was automatically assigned from ethyca/backend

@gilluminate gilluminate Awaiting requested review from gilluminate gilluminate was automatically assigned from ethyca/frontend

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erosselli @adamsachs