Skip to content

Conversation

@etr
Copy link
Owner

@etr etr commented Jun 8, 2019

Identify the Bug

#147

Description of the Change

Avoids accidental pointer arithmetic by converting the integer (port) to string before concatenating.

Alternate Designs

N/D

Possible Drawbacks

None

Verification Process

Autobuild on travis

Release Notes

Fix segfault on message output when a port is already occupied

@etr etr self-assigned this Jun 8, 2019
@etr etr added the bug Confirmed bugs or reports that are very likely to be bugs. label Jun 8, 2019
@codecov-io
Copy link

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files          34       34           
  Lines        3019     3019           
=======================================
  Hits         2915     2915           
  Misses        104      104
Impacted Files Coverage Δ
src/webserver.cpp 88.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d5e0f...0b1e6ac. Read the comment docs.

@etr etr merged commit b911c89 into master Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Confirmed bugs or reports that are very likely to be bugs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants