Simplify libmicrohttpd dependency configuration#223
Merged
Conversation
etr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Removes compilation options to manage usage of select/poll/epoll. The code now makes use of MHD_USE_AUTO flag internally which automatically decides the best dispatch method.
Alternate Designs
Keep the current custom implementation. The downside would be that the configuration is more complex and error prone.
Possible Drawbacks
Performance issues. These have been verified in local and will be further verified as part of the validation process in github actions.
The change also requires a bump in the minimum required version of libmicrohttpd (from 0.9.52 to 0.9.53) - this is a minor version only so the issue should be minimal.
Verification Process
Manual validation through unit testing + local performance testing using apache benchmark (no visible improvement nor degradation of performance). Additional validation will be performed through github actions.
Release Notes
The package now does not require configuration flags to manage the internal dispatch method (poll/epoll/select).