Using full path for includes #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr
added
build-system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
cppcheck introduced a new check that requires paths to be specified in local includes.
Description of the Change
Fixed paths of all includes.
Alternate Designs
Two alternatives: (1) ignore the check and disable it and (2) use the root path in the test Makefile.am thus allowing to pass actual paths (not relative).
(1) is sub-optimal as the check is justified for most of the codebase.
(2) would have worked but might have caused more issues of polluting the include path for tests.
Possible Drawbacks
Tests use includes from the root-src and root-test. These are included with a prefix like './'.
This might lead to issues if those files are moved in the codebase. Given this happens only for 'httpserver.hpp' and 'littletest.hpp' the issue seems unlikely.
Verification Process
Test execution in local and through github actions.
Release Notes
Using full path on includes.