using m4 to define major,minor and revision number in configure.ac#29
Merged
Conversation
…d send version number to libtool and AC_INIT
etr
pushed a commit
that referenced
this pull request
Jul 25, 2012
using m4 to define major,minor and revision number in configure.ac
etr
added a commit
that referenced
this pull request
May 28, 2026
Major findings resolved: - peer_address.cpp: add static_cast<unsigned> before IPv6 byte shifts to eliminate signed-int promotion UB and %x format-specifier mismatch (findings #1/#25, CWE-704) - webserver_impl.hpp: rewrite any_hooks_ comment — remove "relaxed", expand acquire-pairing rationale with the correct hot-path pattern (finding #2, race-condition risk in future TASK-046+ consumers) - hook_handle.hpp: add @warning lifetime block documenting the raw-pointer use-after-free risk and safe usage patterns (finding #3, CWE-416) - webserver_impl.hpp: add phase_hook_count(hook_phase) accessor; test phase_size helper now delegates to it, decoupling test from field names (finding #4) Minor findings resolved: - hook_phase.hpp: remove verbose std::string_view{} wrappers from to_string - hook_action.hpp: add assert(response_.has_value()) precondition guard in take_response() (finding #26, CWE-476) - hook_context.hpp: add @security doc blocks on request_received_ctx and before_handler_ctx mutable pointer fields (finding #27) - hook_context.hpp: update to_string placement comment (finding #28) - hook_handle.cpp: use erase_if_found return value in each switch arm to skip gate reset on no-op erase; add explanatory comment (findings #9/#10/#19) - hook_handle.cpp: add detach() inline comment distinguishing detached-disarmed from default-disarmed state (finding #8) - hook_handle.cpp: add TODO comment on switch repetition trade-off (#7/#17) - webserver.cpp: add comment on any_hooks_ store-under-lock redundancy (#24) - test: add add_hook_throws_on_phase_mismatch + add_hook_throws_on_empty_callable runtime tests (finding #11) - test: strengthen double_remove_is_noop with observable assertions (#12/#32) - test: capture detached handle in detach_disarms_destructor (#13) - test: add move_assign_removes_target_registration runtime test (#14) - test: verify take_response() returns correct status in hook_action test (#31) - test: add second remove() to default_constructed_handle_is_inert (#33) - test: add accept_decision_hook_callable pinned-phase SFINAE static_assert (#34) - test: add design-intent comment explaining compile-time vs runtime split (#29) - spec: mark all 34 items resolved/deferred in findings file Deferred: hooks.md doc updates (#5/#6), detach refactor (#15/#18), lambda inlining (#16), port 0 cleanup (#30), per-phase mutex (#23). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
etr
added a commit
that referenced
this pull request
May 28, 2026
Major fixes: - Extract as_shared() to test/integ/test_utils.hpp (DRY: removes 10 verbatim copies from integ TUs; fixes majors #2, #3 and minors #9, #16, #27). Add safety contract documentation in the header. Update test/Makefile.am noinst_HEADERS. - Add performance note in webserver_impl.hpp documenting the v1 route_cache_mutex_ serialization bottleneck and future migration path to route_cache_v2 (major #4). - Document §4.7 compliance status: route_entry variant exists in the v2 3-tier table (route_entry.hpp); v1 maps are transitional legacy flagged for Cycle K removal (major #1). Minor fixes: - Reword duplicate-registration comment to accurately describe both unique_ptr and shared_ptr ownership paths (#7, #8). - Add lock-order explanation before manual registered_resources_lock .unlock() call (#15, #18). - Rename is_exact to is_plain_path with explanatory comment (#14). - Rename fe to exact_it in resolve_resource_for_request (#17). - Add comments documenting necessary shared_ptr copies on hot paths to prevent reviewers from "optimising" them away (#19, #21). - Add curl_global_cleanup() after curl_easy_cleanup in unique_ptr_overload_compiles_and_serves (#11). - Document PORT macro sequential assumption and ephemeral-port migration path (#10, #13). - Add compile-time vs runtime note on unique_ptr_overload test (#28). - Rename threw to caught_invalid_argument in null/dup throw tests with post-catch assertion (#29). - Add comment in set_up documenting dtor_count reset dependency (#30). - Various already-addressed items noted in spec (ws raw pointer removed #5/#26, unregister implicit-conversion bug fixed #22). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
etr
added a commit
that referenced
this pull request
May 28, 2026
Final cleanup pass over the unworked review issues tracker: - Flipped 7 checkboxes whose *Status:* already indicated Resolved / Accepted / No-action (task-028 #9/#25, task-031 #25/#27/#28/#29/#35). - Converted 74 clearly-cosmetic deferrals (naming preferences, idiom choices, comment trim suggestions, "consider renaming" notes) to explicit *Status:* wontfix. Kept the checkbox as [ ] so they remain visible in the open list but are no longer in the actionable backlog. Final state of specs/unworked_review_issues/: - 1974 total findings across 37 review files - 1578 closed [x] / [~] (80%) - 322 still-open deferred (actionable backlog) - 74 wontfix (cosmetic, explicit close) - 0 items missing a *Status:* line The 322 actionable deferrals skew toward substantive backlog: missing tests, missing input validation, perf hot paths, refactor candidates, and spec/architecture drift. The full list of "real engineering work worth a follow-up pass" surfaced by Passes 1-3 is preserved in each review file's *Status:* lines. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thanks to m4_define the version number can be composed before AC_INIT call.
Version number is sent to libtool via '-version-info` option