Skip to content

Conversation

@etr
Copy link
Owner

@etr etr commented Dec 12, 2022

Identify the Bug

With the update of github actions to the latest version of ubuntu, we moved the library to build on clang-13 and gcc-10. Both have added additional warnings that this PR attempts to fix.

  1. The order in which libraries are included in deferred.cpp is wrong and mixes C includes with C++ includes.
  2. msan is mistakenly finding issues in system libraries.

Description of the Change

Re-order the includes in deferred.cpp.
Force msan to ignore functions from system libraries.

Alternate Designs

None.

Possible Drawbacks

None.

Verification Process

Build process which includes testing.

@etr etr merged commit f914067 into master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants