fix #292 handle argument keys with multiple values #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the server to handle argument keys with multiple values e.g. url?arg=param&arg=what Previous, the arg key would just be overwritten with the next value. This change adds a http_arg_value type to house all the values for a given key. Adjust existing get_arg(s) methods, and add some get_arg_flat type methods that still just return the first value for a given key. Add a test case for multiple valued keys. Add a test case for a large file upload that triggers chunking behavior of MHD. This causes the server to concatenate file chunks within the first value of the given arg key, so the test ensures that this behavior is not affected by the changes.
This change allows the server to handle argument keys with multiple values e.g. url?arg=param&arg=what Previous, the arg key would just be overwritten with the next value. This change adds a http_arg_value type to house all the values for a given key. Adjust existing get_arg(s) methods, and add some get_arg_flat type methods that still just return the first value for a given key. Add a test case for multiple valued keys. Add a test case for a large file upload that triggers chunking behavior of MHD. This causes the server to concatenate file chunks within the first value of the given arg key, so the test ensures that this behavior is not affected by the changes.
This change allows the server to handle argument keys with multiple values e.g. url?arg=param&arg=what Previous, the arg key would just be overwritten with the next value. This change adds a http_arg_value type to house all the values for a given key. Adjust existing get_arg(s) methods, and add some get_arg_flat type methods that still just return the first value for a given key. Add a test case for multiple valued keys. Add a test case for a large file upload that triggers chunking behavior of MHD. This causes the server to concatenate file chunks within the first value of the given arg key, so the test ensures that this behavior is not affected by the changes.
This change allows the server to handle argument keys with multiple values e.g. url?arg=param&arg=what Previous, the arg key would just be overwritten with the next value. This change adds a http_arg_value type to house all the values for a given key. Adjust existing get_arg(s) methods, and add some get_arg_flat type methods that still just return the first value for a given key. Add a test case for multiple valued keys. Add a test case for a large file upload that triggers chunking behavior of MHD. This causes the server to concatenate file chunks within the first value of the given arg key, so the test ensures that this behavior is not affected by the changes.
This change allows the server to handle argument keys with multiple values e.g. url?arg=param&arg=what Previous, the arg key would just be overwritten with the next value. This change adds a http_arg_value type to house all the values for a given key. Adjust existing get_arg(s) methods, and add some get_arg_flat type methods that still just return the first value for a given key. Add a test case for multiple valued keys. Add a test case for a large file upload that triggers chunking behavior of MHD. This causes the server to concatenate file chunks within the first value of the given arg key, so the test ensures that this behavior is not affected by the changes.
This change allows the server to handle argument keys with multiple values e.g. url?arg=param&arg=what Previous, the arg key would just be overwritten with the next value. This change adds a http_arg_value type to house all the values for a given key. Adjust existing get_arg(s) methods, and add some get_arg_flat type methods that still just return the first value for a given key. Add a test case for multiple valued keys. Add a test case for a large file upload that triggers chunking behavior of MHD. This causes the server to concatenate file chunks within the first value of the given arg key, so the test ensures that this behavior is not affected by the changes.
etr
reviewed
Mar 6, 2023
This change allows the server to handle argument keys with multiple values e.g. url?arg=param&arg=what Previous, the arg key would just be overwritten with the next value. This change adds a http_arg_value type to house all the values for a given key. Adjust existing get_arg(s) methods, and add some get_arg_flat type methods that still just return the first value for a given key. Add a test case for multiple valued keys. Add a test case for a large file upload that triggers chunking behavior of MHD. This causes the server to concatenate file chunks within the first value of the given arg key, so the test ensures that this behavior is not affected by the changes.
mdf-observe
reviewed
Mar 6, 2023
etr
reviewed
Mar 6, 2023
etr
reviewed
Mar 6, 2023
test/integ/basic.cpp
Outdated
Comment on lines
660
to
662
| // Change the content type to trigger "normal" POST processing, | ||
| // otherwise the file processing logic is triggered which does | ||
| // not set the multiple arg values as expected. |
Owner
There was a problem hiding this comment.
I think you might have lost me here. Why does this need to be done?
Contributor
Author
There was a problem hiding this comment.
Without a different content type the defaults that cURL sets trigger the file processing code, but in this test I am just trying to check the "normal" arg handling with multiple values.
etr
reviewed
Mar 6, 2023
This change allows the server to handle argument keys with multiple values e.g. url?arg=param&arg=what Previous, the arg key would just be overwritten with the next value. This change adds a http_arg_value type to house all the values for a given key. Adjust existing get_arg(s) methods, and add some get_arg_flat type methods that still just return the first value for a given key. Add a test case for multiple valued keys. Add a test case for a large file upload that triggers chunking behavior of MHD. This causes the server to concatenate file chunks within the first value of the given arg key, so the test ensures that this behavior is not affected by the changes.
This change allows the server to handle argument keys with multiple values e.g. url?arg=param&arg=what Previous, the arg key would just be overwritten with the next value. This change adds a http_arg_value type to house all the values for a given key. Adjust existing get_arg(s) methods, and add some get_arg_flat type methods that still just return the first value for a given key. Add a test case for multiple valued keys. Add a test case for a large file upload that triggers chunking behavior of MHD. This causes the server to concatenate file chunks within the first value of the given arg key, so the test ensures that this behavior is not affected by the changes.
Contributor
Author
|
Some auto checks were cancelled? Never seen that before! |
Owner
I suspect that github has finally deprecated ubuntu 18.04 - I've started noticing this issue elsewhere as well. I think we can ignore that check for the purpose of this PR. |
This change allows the server to handle argument keys with multiple values e.g. url?arg=param&arg=what Previous, the arg key would just be overwritten with the next value. This change adds a http_arg_value type to house all the values for a given key. Adjust existing get_arg(s) methods, and add some get_arg_flat type methods that still just return the first value for a given key. Add a test case for multiple valued keys. Add a test case for a large file upload that triggers chunking behavior of MHD. This causes the server to concatenate file chunks within the first value of the given arg key, so the test ensures that this behavior is not affected by the changes.
This change allows the server to handle argument keys with multiple values e.g. url?arg=param&arg=what Previous, the arg key would just be overwritten with the next value. This change adds a http_arg_value type to house all the values for a given key. Adjust existing get_arg(s) methods, and add some get_arg_flat type methods that still just return the first value for a given key. Add a test case for multiple valued keys. Add a test case for a large file upload that triggers chunking behavior of MHD. This causes the server to concatenate file chunks within the first value of the given arg key, so the test ensures that this behavior is not affected by the changes.
This change allows the server to handle argument keys with multiple values e.g. url?arg=param&arg=what Previous, the arg key would just be overwritten with the next value. This change adds a http_arg_value type to house all the values for a given key. Adjust existing get_arg(s) methods, and add some get_arg_flat type methods that still just return the first value for a given key. Add a test case for multiple valued keys. Add a test case for a large file upload that triggers chunking behavior of MHD. This causes the server to concatenate file chunks within the first value of the given arg key, so the test ensures that this behavior is not affected by the changes.
etr
reviewed
Mar 8, 2023
| **/ | ||
| class arg_comparator { | ||
| public: | ||
| using is_transparent = std::true_type; |
Owner
There was a problem hiding this comment.
What is this doing? (I cannot find it used elsewhere)
Contributor
Author
There was a problem hiding this comment.
This is required to activate heterogeneous lookup using this comparator. is_transparent just needs to be defined, it doesn't get referenced anywhere. From cppreference:
The member type is_transparent indicates to the caller that this function object is a transparent function object: it accepts arguments of arbitrary types and uses perfect forwarding, which avoids unnecessary copying and conversion when the function object is used in heterogeneous context, or with rvalue arguments. In particular, template functions such as std::set::find and std::set::lower_bound make use of this member type on their Compare types.
Owner
There was a problem hiding this comment.
oh cool. I learned something :). Thank you!
etr
reviewed
Mar 8, 2023
This change allows the server to handle argument keys with multiple values e.g. url?arg=param&arg=what Previous, the arg key would just be overwritten with the next value. This change adds a http_arg_value type to house all the values for a given key. Adjust existing get_arg(s) methods, and add some get_arg_flat type methods that still just return the first value for a given key. Add a test case for multiple valued keys. Add a test case for a large file upload that triggers chunking behavior of MHD. This causes the server to concatenate file chunks within the first value of the given arg key, so the test ensures that this behavior is not affected by the changes.
Owner
|
Thanks for the change and for the patience to go through the review process. I think this is a great feature to have in the library. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
#292
Description of the Change
This change allows the server to handle argument keys with multiple values e.g. url?arg=param&arg=what
Previous, the arg key would just be overwritten with the next value. This change adds a http_arg_value type to house all the values for a given key.
Adjust existing get_arg(s) methods, and add some get_arg_flat type methods that still just return the first value for a given key.
Add a test case for multiple valued keys.
Add a test case for a large file upload that triggers chunking behavior of MHD. This causes the server to concatenate file chunks within the first value of the given arg key, so the test ensures that this behavior is not affected by the changes.
Alternate Designs
Design is according to discussion in #292
Possible Drawbacks
Small changes to public API.
Verification Process
Additional testing added as in change description. In particular, verify that large file handling behavior has not regressed.
Release Notes
get_arg()now returns anhttp_arg_valuetype containing a collection of all values associated with the requested key.get_arg_flat()retains the old behavior where just one value is selected and returned.