Consider family_url in ordering of http_endpoint. #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr
reviewed
Apr 3, 2023
…ling register_resource independently for a path as a family and non-family.
bcsgh
force-pushed
the
bcsgh/fix-register_resource-family
branch
from
e751ccb to
f7dc3af
Compare
etr
reviewed
Apr 11, 2023
Owner
|
Thanks for the change. This is really helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow calling register_resource independently for a path as a family and non-family.
Requirements for Contributing a Bug Fix
Identify the Bug
#305
Description of the Change
Consider family_url in ordering of http_endpoint.
Alternate Designs
None.
Possible Drawbacks
This will change behavior of programs in some cases. In general however, those cases are already not doing what the user likely expects.
Verification Process
TBD
Release Notes
Allow register_resource to use the same path for family and non-family cases in the same webserver.