Skip to content

Update image templating logic#7

Merged
jumbosushi merged 2 commits intomainfrom
ay/template-external-images
Mar 26, 2025
Merged

Update image templating logic#7
jumbosushi merged 2 commits intomainfrom
ay/template-external-images

Conversation

@jumbosushi
Copy link
Copy Markdown

@jumbosushi jumbosushi commented Mar 24, 2025

Description

  • Specify repo package when using root-level images (e.g. from oci_pulls)
  • Handle when image field in a yaml uses :image or @image labels
  • Update image targets in container env vars for particular cases

Motivation and Context

Current templating logic missed some image use cases in Sciences.

How Has This Been Tested?

Tested with Sciences code

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@jumbosushi jumbosushi requested a review from shraykay March 24, 2025 23:47
@jumbosushi jumbosushi merged commit e7c3355 into main Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants