fix: registration #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a registration issue by adding null checking for account ID before fetching bookings and restructuring the booking retrieval logic.
Key Changes
- Added null check for
accountIdbefore making booking API calls - Moved booking assignment logic outside the API call to handle null account scenarios
- Changed fallback value for
attendeeIdfrom empty string to "-1"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| let booking: Booking | null = null; | ||
| if (accountId != null && accountId.trim().length > 0) { | ||
| const { data: bookings } = await getBookings({ | ||
| attendeeId: accountId ?? "-1", |
There was a problem hiding this comment.
Using '-1' as a fallback attendeeId could cause issues if the API doesn't handle this value properly. Consider using a more explicit fallback like null or throwing an error, since the null check above should prevent this case from occurring.
Suggested change
| attendeeId: accountId ?? "-1", | |
| attendeeId: accountId, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.