Add reading and writing observable in hdf5 #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-br
requested changes
Mar 16, 2022
Owner
There was a problem hiding this comment.
Looks reasonable as a first implementation.
Let's keep h5py as an optional dependency, hence wrap the imports into try-catch blocks. On CI, add h5py on this line: https://github.com/ev-br/mc_lib/blob/master/.github/workflows/dev_ubuntu_macos.yml#L45 -- this way tests will exercise installs with both hdf5 present and not present.
Owner
|
Next, can you add an example of saving several observables to a single hdf5 file @MoskalenkoRomanBorisovich |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ev-br
approved these changes
Mar 21, 2022
Owner
|
LGTM now, thanks @MoskalenkoRomanBorisovich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.