clean up some cruft#2
Merged
Merged
Conversation
Also, * export and distinguish const and non-const iterators * do not use data_ directly * do not dereference end() iterator :-)
And use random matrices in tests. GEMM fails :-(
Neither of .todense, .inplace_unary/binop, .apply_binop, .apply_mmul need to be a member. Also manually inline get/set_one in operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganize the cpp innards a bit: move operations to be non-members; minimize the inner API surface (will be easier to add views later on).