Skip to content

Fix #889: bears_object() now recognizes array types as objects#890

Merged
haeter525 merged 3 commits intomasterfrom
swe-agent-fix-#889-53135393
Apr 3, 2026
Merged

Fix #889: bears_object() now recognizes array types as objects#890
haeter525 merged 3 commits intomasterfrom
swe-agent-fix-#889-53135393

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Mar 23, 2026

Closes #889

Key Changes:

Tests:

  • pytest tests/core/struct/test_registerobject.py — all test_bears_object cases pass
  • Smoke test against Ahmyth.apk reports 39 behaviors at 100% confidence for Rule 00015

@haeter525 haeter525 force-pushed the swe-agent-fix-#889-53135393 branch from c6efb82 to f1c0ff5 Compare March 23, 2026 09:05
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.31%. Comparing base (94c0d0e) to head (1cbe41a).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #890   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files          80       80           
  Lines        6946     6946           
=======================================
  Hits         5648     5648           
  Misses       1298     1298           
Flag Coverage Δ
unittests 81.31% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@haeter525 haeter525 changed the title SWE-agent[bot] PR to fix: PyEval Fails to Track Byte Array Registers Fix #889: PyEval fails to track byte array registers Mar 23, 2026
@haeter525 haeter525 marked this pull request as ready for review March 23, 2026 09:56
Cover [Ljava/lang/String; and [[B type descriptors, which both start
with "[" and should return True from bears_object().
@haeter525 haeter525 changed the title Fix #889: PyEval fails to track byte array registers Fix #889: Recognize array types as objects in bears_object Mar 23, 2026
@haeter525 haeter525 changed the title Fix #889: Recognize array types as objects in bears_object Fix #889: PyEval fails to track byte array registers Mar 23, 2026
@haeter525 haeter525 changed the title Fix #889: PyEval fails to track byte array registers Fix #889: bears_object() now recognizes array types as objects Mar 23, 2026
Copy link
Copy Markdown
Member

@pulorsok pulorsok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haeter525 haeter525 merged commit 0f29053 into master Apr 3, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyEval Fails to Track Byte Array Registers

2 participants