Fix #889: bears_object() now recognizes array types as objects#890
Merged
Fix #889: bears_object() now recognizes array types as objects#890
Conversation
c6efb82 to
f1c0ff5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #890 +/- ##
=======================================
Coverage 81.31% 81.31%
=======================================
Files 80 80
Lines 6946 6946
=======================================
Hits 5648 5648
Misses 1298 1298
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cover [Ljava/lang/String; and [[B type descriptors, which both start with "[" and should return True from bears_object().
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #889
Key Changes:
bears_object()to returnTruefor array types starting with[[B,[Ljava/lang/String;, and[[BtypesTests:
pytest tests/core/struct/test_registerobject.py— alltest_bears_objectcases passAhmyth.apkreports 39 behaviors at 100% confidence for Rule 00015