Expose public Device interface #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://www.python.org/dev/peps/pep-0343/ The cached file handles should be closed by the default destructor anyway.
And make it compatible with boostc version of python bindings. Also get rid of leading double underscores in private member names. See https://www.python.org/dev/peps/pep-0008/#method-names-and-instance-variables
list(string) makes a list of characters contained in the string, and not a list with single string entry as I thought. Also, clean up self._path if no device was connected.
Member
Author
|
I also found a bug in my initial implementation of |
rhempel
added a commit
that referenced
this pull request
Oct 16, 2015
Expose public Device interface
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit removes the
__exit__method fromDevicewhich has no use without the corresponding__enter__method anyway (see https://www.python.org/dev/peps/pep-0343/). If this was intended to be a destructor, it should be called__del__, but that is not needed either, since default destructor should delete the file cache and close the file handles automatically.The second commit exposes methods of the
Deviceclass as public, and makes the names compatible with boostc version of python bindings. If you don't like the new method names, we can discuss it, but I think it should be possible for the user to use rawDeviceclass (hence, the methods should definitely be public).The commit also gets rid of leading double underscores in private member names. See https://www.python.org/dev/peps/pep-0008/#method-names-and-instance-variables.