Flake8 #723
Merged
Flake8 #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 9, 2020 10:44
Collaborator
Author
|
For issue #714 |
Member
|
This seems generally OK, but I think a lot of this functionality should be tested if we're making these changes, because some of it could have introduced bugs. |
Collaborator
Author
|
@WasabiFan I’ll do some testing tonight and then merge. I looked through the patch again and all of the changes look pretty trivial so I think after some basic testing we should be good. |
Collaborator
Author
|
I did some testing...all seems fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects all warning/errors found by flake8