Skip to content

Various small refactors#182

Merged
xzrderek merged 5 commits intomainfrom
derekx/base-adapter
Sep 17, 2025
Merged

Various small refactors#182
xzrderek merged 5 commits intomainfrom
derekx/base-adapter

Conversation

@xzrderek
Copy link
Copy Markdown
Contributor

No description provided.

@xzrderek xzrderek requested a review from dphuang2 September 17, 2025 08:46
Comment on lines -59 to -60
async def test_llm_judge(rows: list[EvaluationRow]) -> list[EvaluationRow]:
return await aha_judge(rows)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes thank you

Comment on lines +19 to +21
async def aha_judge(
rows: list[EvaluationRow], judge_name: str = "gemini-2.5-pro", adapter: Optional[BaseAdapter] = None
) -> list[EvaluationRow]:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly

Comment on lines +49 to +50
async def test_llm_judge(rows: list[EvaluationRow]) -> list[EvaluationRow]:
return await aha_judge(rows)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clean

Copy link
Copy Markdown
Collaborator

@dphuang2 dphuang2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@xzrderek xzrderek merged commit bcda711 into main Sep 17, 2025
1 check passed
@xzrderek xzrderek deleted the derekx/base-adapter branch September 17, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants