fix external import error #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mayinghan
commented
Sep 23, 2025
mayinghan
commented
dphuang2
reviewed
Sep 23, 2025
|
|
||
| def _responses_tools_to_chat_completion_tools( | ||
| self, tools: List[Tool] | ||
| ) -> Sequence[ChatCompletionFunctionToolParam]: |
Collaborator
There was a problem hiding this comment.
sorry, what is this change? was it incorrect before?
Collaborator
Author
There was a problem hiding this comment.
i think its a version issue, i tested in a clean env (0 previous installed dependencies in it) and it complained on this import.
dphuang2
reviewed
Sep 23, 2025
Comment on lines
+44
to
+47
| try: | ||
| from .adapters import OpenAIResponsesAdapter | ||
| except ImportError: | ||
| OpenAIResponsesAdapter = None |
dphuang2
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.