Skip to content

make remote rollout processor respect max_concurrent_rollout #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xzrderek merged 1 commit into from
Sep 29, 2025
Merged

make remote rollout processor respect max_concurrent_rollout #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions eval_protocol/pytest/remote_rollout_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,14 @@ def _load_data():
else:
raise ValueError("RemoteRolloutProcessor's output_data_loader should return exactly one row.")

for r in rows:
tasks.append(asyncio.create_task(_process_row(r)))
semaphore = config.semaphore

async def _sem_wrapper(r: EvaluationRow) -> EvaluationRow:
async with semaphore:
result = await _process_row(r)
return result

tasks = [asyncio.create_task(_sem_wrapper(row)) for row in rows]
return tasks

def cleanup(self) -> None:
Expand Down
Loading