Conversation
xzrderek
commented
Oct 26, 2025
dphuang2
approved these changes
Oct 26, 2025
Collaborator
dphuang2
left a comment
There was a problem hiding this comment.
one nit, should be easy to fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Introduce
proxyoptional extra with required deps and explicit ImportError fallbacks; update remote Fireworks tests to fetch traces via adapter and adjust CI to ignore them.eval_protocol/__init__.pyforcreate_app,AuthProvider, andAccountInfothat raiseImportErrorwith install hint when proxy deps are missing (withpyrightignore for type).proxyextra inpyproject.tomlwithredis,langfuse, anduuid6.tests/remote_server/test_remote_fireworks.py: add Fireworks tracing output data loader (fireworks_output_data_loader) to fetch traces viaFireworksTracingAdapter; track and assert multiplerollout_ids; increase timeout.tests/remote_server/test_remote_fireworks_propagate_status.py: add Fireworks tracing output data loader and use it inRemoteRolloutProcessorwhile asserting propagated error status..github/workflows/ci.ymlto ignoretests/remote_server/test_remote_fireworks.py(and keep ignoring the propagate-status test) in parallel test run.uv.lockto includeproxyextras and packages (redis,langfuse,uuid6).Written by Cursor Bugbot for commit d42e464. This will update automatically on new commits. Configure here.