Skip to content

filter fields in rollout#309

Merged
mayinghan merged 1 commit intomainfrom
filter-field-from-message
Nov 3, 2025
Merged

filter fields in rollout#309
mayinghan merged 1 commit intomainfrom
filter-field-from-message

Conversation

@mayinghan
Copy link
Collaborator

@mayinghan mayinghan commented Nov 2, 2025


name: Pull Request
about: Propose changes to the codebase
title: "Brief description of changes"
labels: ''
assignees: ''


Description

Please include a summary of the change and which issue is fixed or feature is implemented. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
Implements # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactoring/Code cleanup
  • Build/CI/CD related changes
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project (ran black ., isort ., flake8 .)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots (if applicable)

If applicable, add screenshots to help showcase your changes.

Additional context

Add any other context about the PR here.


Note

Filters unsupported Message fields before API requests across rollout processors and tracing, using dump_mdoel_for_chat_completion_request, and adds tests to verify.

  • Rollout Processing:
    • Agent: Use Message.dump_mdoel_for_chat_completion_request() to build messages_payload, excluding unsupported fields before LLM call in default_agent_rollout_processor.py.
    • Single-turn: Build messages_payload via dump_mdoel_for_chat_completion_request() to strip unsupported fields in default_single_turn_rollout_process.py.
  • Tracing:
    • In tracing_utils.build_init_request, prefer dump_mdoel_for_chat_completion_request() and additionally keep only allowed keys (role, content, tool_calls, tool_call_id, name).
  • Tests:
    • Add tests/test_message_field_filtering.py to verify unsupported fields (weight, control_plane_step, reasoning_content) are excluded and supported fields are preserved.

Written by Cursor Bugbot for commit 28285ee. This will update automatically on new commits. Configure here.

@mayinghan mayinghan requested review from benjibc and xzrderek November 2, 2025 21:13
@mayinghan mayinghan merged commit 5adf5f2 into main Nov 3, 2025
9 checks passed
@mayinghan mayinghan deleted the filter-field-from-message branch November 3, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants