Skip to content

Tinker example#340

Merged
benjibc merged 3 commits intomainfrom
tinker_example
Nov 20, 2025
Merged

Tinker example#340
benjibc merged 3 commits intomainfrom
tinker_example

Conversation

@benjibc
Copy link
Contributor

@benjibc benjibc commented Nov 20, 2025

Note

Introduce Tinker-based rollout/evaluation with an eval_protocol adapter-to-RL bridge and a GSM8K RL training example with metrics plotting.

  • Integrations (tinker-cookbook):
    • EvalProtocolRLDataset, EvalProtocolEvaluator, and create_eval_protocol_dataset_builder to bridge eval_protocol adapters to Tinker RL datasets/evaluators.
    • TinkerRolloutProcessor implementing rollouts via Tinker SamplingClient, renderer/tokenizer setup, and async batching.
  • Examples (GSM8K RL):
    • examples/tinker_math_rl/train.py: end-to-end RL training using GSM8K adapter, row conversion to ProblemGroupBuilder, and periodic evaluation.
    • examples/tinker_math_rl/test_gsm8k_eval.py: evaluation test using TinkerRolloutProcessor and GSM8K rows.
    • examples/tinker_math_rl/plot_metrics.py: plot training metrics.
    • examples/tinker_math_rl/README.md: setup and run instructions.

Written by Cursor Bugbot for commit 8a1b8f0. This will update automatically on new commits. Configure here.

from eval_protocol.integrations.tinker_rollout_processor import TinkerRolloutProcessor

# Import test components
from examples.tinker_math_rl.test_gsm8k_eval import test_gsm8k_tinker, get_gsm8k_input_rows
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Broken import path in training script

The script attempts to import test_gsm8k_eval using the full path examples.tinker_math_rl, which fails with ModuleNotFoundError when running python train.py from the directory as documented. The examples package is not in sys.path in that context; use a relative or direct import instead.

Fix in Cursor Fix in Web

@benjibc benjibc merged commit 936f4a5 into main Nov 20, 2025
9 checks passed
@benjibc benjibc deleted the tinker_example branch November 20, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant