Skip to content

reduce collision#343

Merged
mayinghan merged 2 commits intomainfrom
reduce_collisions
Nov 25, 2025
Merged

reduce collision#343
mayinghan merged 2 commits intomainfrom
reduce_collisions

Conversation

@benjibc
Copy link
Contributor

@benjibc benjibc commented Nov 24, 2025

Note

Expand human-readable IDs to 6-digit numeric suffix and update tests, adding a fallback EchoEnv import for OpenEnv tests.

  • human_id:
    • Expand ID format from adjective-noun-NN to adjective-noun-NNNNNN.
    • Update deterministic index mapping, range checks, and formatting to 6 digits; num_combinations() now multiplies by 1_000_000.
  • Tests:
    • Update tests/test_human_id.py to expect 6-digit numeric suffix and new index rollover points.
    • In tests/pytest/test_openenv_echo_hub.py, wrap EchoEnv import in try/except and provide a dummy EchoEnv fallback for environments without openenv.

Written by Cursor Bugbot for commit b844a72. This will update automatically on new commits. Configure here.

@mayinghan mayinghan merged commit 5468710 into main Nov 25, 2025
9 checks passed
@mayinghan mayinghan deleted the reduce_collisions branch November 25, 2025 00:29
@dphuang2
Copy link
Collaborator

😮 there were collisions? thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants