differentiate skippable exception and non-skippable exception#96
Merged
differentiate skippable exception and non-skippable exception#96
Conversation
benjibc
approved these changes
Aug 19, 2025
xzrderek
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing a new custom Exception type: RolloutTerminationException, which means the rollout should be interrupted but the trajectory should be kept for future evaluation or analysis, unlike the system retryable errors such as network error or timeout.For error messages, we pass it from control_plane_summary and then preserve them into the rollout_status.extra_info, and align the rollout_status.termination_reason with the TerninationReason enum.In practice, we should expect custom Policy implementation can throw RolloutTerminationException to terminate the rollout, while keeping the rollout_status.status as "finished" to make sure poeople wont filter these results when doing post processing or evaluationDifferentiate SKIPPABLE_ERROR & NON_SKIPPABLE_ERROR in rollout
rollout_status.statusasfinishedwhile marking therollout_status.termination_reasonas NON_SKIPPABLE_ERROR. The rest exceptions will be raised to upper layers, and will be handled inside rollout_processors.