Merged
Conversation
gertjanvanzwieten
force-pushed
the
simplify
branch
4 times, most recently
from
1a22630 to
2886bbf
Compare
joostvanzwieten
approved these changes
Apr 6, 2020
gertjanvanzwieten
force-pushed
the
simplify
branch
from
2886bbf to
378b415
Compare
The problem with setting dtype to integer is that nan-values are silently mapped to the maximum integer value, with the potential for obscure errors.
gertjanvanzwieten
force-pushed
the
simplify
branch
from
378b415 to
4555a61
Compare
gertjanvanzwieten
force-pushed
the
simplify
branch
from
4555a61 to
7fe9a76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.