Skip to content

ci: skip feedback artifacts after preflight failure #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haasonsaas merged 1 commit into from
May 10, 2026
Merged

ci: skip feedback artifacts after preflight failure #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/review-feedback-backfill.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
fi

- name: Run review feedback backfill
id: backfill
run: |
set +e
ruby .github/scripts/sweep-recent-review-feedback.rb \
Expand Down Expand Up @@ -72,7 +73,7 @@ jobs:
exit "${status}"

- name: Upload review feedback 30-day ledger
if: always()
if: ${{ always() && steps.backfill.outcome != 'skipped' }}
uses: actions/upload-artifact@v4
with:
name: review-feedback-30d-ledger
Expand All @@ -83,7 +84,7 @@ jobs:
retention-days: 90

- name: Upload review feedback 30-day guardrail backlog
if: always()
if: ${{ always() && steps.backfill.outcome != 'skipped' }}
uses: actions/upload-artifact@v4
with:
name: review-feedback-30d-guardrail-backlog
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/review-feedback-sentinel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
fi

- name: Sweep recent merged PR feedback
id: sweep
run: |
set +e
ruby .github/scripts/sweep-recent-review-feedback.rb \
Expand Down Expand Up @@ -74,7 +75,7 @@ jobs:
exit "${status}"

- name: Upload review feedback ledger
if: always()
if: ${{ always() && steps.sweep.outcome != 'skipped' }}
uses: actions/upload-artifact@v4
with:
name: review-feedback-ledger
Expand All @@ -83,7 +84,7 @@ jobs:
retention-days: 30

- name: Upload review feedback guardrail backlog
if: always()
if: ${{ always() && steps.sweep.outcome != 'skipped' }}
uses: actions/upload-artifact@v4
with:
name: review-feedback-guardrail-backlog
Expand Down
Loading