Add evidence redaction and log integrity#10
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
haasonsaas
commented
May 26, 2026
Contributor
Author
haasonsaas
left a comment
There was a problem hiding this comment.
Review pass completed on the current PR head.
What I checked:
- Evidence writes now redact common secret-like values before JSONL persistence, including send keys, exec argv, policy command text, observations, and git snapshots.
- Event sequencing and previous-hash/event-hash chaining are computed while holding the append lock, so concurrent appenders cannot race the chain.
- Proof bundles surface log-integrity status in JSON, Markdown, and HTML, and the tmux smoke artifacts show
Log integrity: verified. - Regression coverage includes redaction, tamper detection, proof integrity, full cargo integration coverage, and the ignored tmux black-box harness.
Residual caveat: redaction is intentionally heuristic for common agent secret shapes, not a full DLP engine. That is documented by the wording in README and should be expanded later with configurable redaction policy.
Verification run:
git diff --checkcargo test --test security_evidence -- --nocapturecargo fmt -- --checkcargo clippy --all-targets --all-features -- -D warningscargo testcargo build --releasecargo test --test e2e_tmux -- --ignored --nocapturegh pr checks 10 --repo evalops/agent-pty
No blocking findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
git diff --checkcargo test --test security_evidence -- --nocapturecargo fmt -- --checkcargo clippy --all-targets --all-features -- -D warningscargo testcargo build --releasecargo test --test e2e_tmux -- --ignored --nocaptureSmoke coverage
Log integrity: verified