Expose Redis pool metrics

[haasonsaas]

Summary

• expose Redis pool stats from ASB bootstrap alongside the existing Postgres stats hook
• register shared Redis pool Prometheus collectors for the ASB metrics endpoint
• bump service-runtime to v0.1.17 and cover the Redis metrics output in tests

Testing

• go test ./cmd/asb-api ./internal/bootstrap ./internal/api/httpapi
• go test ./...
• git diff --check

[cursor]

PR Summary

Low Risk
Low risk: adds optional Redis pool Prometheus collectors alongside existing DB stats and extends runtime wiring; behavior is additive and guarded by nil checks.

Overview
Adds Redis pool metrics to the /metrics endpoint by extending bootstrap.ServiceRuntime with a RedisStats hook and wiring it through newRuntimeStore when Redis is configured.

Updates registerRuntimeMetrics to conditionally register both DB and Redis collectors (returning errors per-registration), bumps github.com/evalops/service-runtime to v0.1.17, and adds a test asserting Redis pool metrics output.

^{Reviewed by Cursor Bugbot for commit 8fbb93d. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.}

^{Reviewed by Cursor Bugbot for commit 8fbb93d. Configure here.}

[cursor]

Interface nil check won't catch typed nil values

Low Severity

The redisPoolStats function accepts goredis.UniversalClient (an interface) and uses client == nil as a guard, but this check doesn't catch typed nil values — a well-known Go interface gotcha. If a caller passes a nil *goredis.Client, the interface wrapper is non-nil, so the guard is skipped and client.PoolStats would panic. The companion function pgxPoolDBStats avoids this by accepting the concrete pointer type *pgxpool.Pool, where the nil check works correctly.

 

^{Reviewed by Cursor Bugbot for commit 8fbb93d. Configure here.}