Skip to content

[codex] Harden DiffScope review operations#101

Merged
haasonsaas merged 3 commits into
mainfrom
codex/diffscope-deep-improvements
May 18, 2026
Merged

[codex] Harden DiffScope review operations#101
haasonsaas merged 3 commits into
mainfrom
codex/diffscope-deep-improvements

Conversation

@haasonsaas
Copy link
Copy Markdown
Collaborator

Summary

  • Wire self-hosted server security secrets through Helm, fix the self-hosting chart example, and keep GitHub App/webhook credentials out of config maps.
  • Sandbox custom context and local pattern-repository reads, harden verifier prompts against adversarial finding text, and make DAG retry/timeout hints executable.
  • Move DiffScope dogfood CI to the branch-built binary, add always-on review contract checks, expose learning/evidence state in Doctor, and tighten install/web dependency hygiene.

Why

The prior surface had a few production-risk gaps: the chart set DIFFSCOPE_API_KEY but not DIFFSCOPE_SERVER_API_KEY, context patterns could escape the intended base path, verifier evidence was rendered as ordinary prompt text, and eval gates could disappear when model secrets were absent. This makes those contracts explicit and test-backed.

Validation

  • cargo test (1565 passed)
  • cargo clippy --all-targets -- -D warnings
  • cargo fmt -- --check
  • npm run build
  • npm test (77 passed, 5 skipped)
  • npm audit (0 vulnerabilities)
  • helm lint charts/diffscope
  • helm template diffscope charts/diffscope --set secrets.serverApiKey=server --set secrets.githubWebhookSecret=hook --set secrets.githubAppId=123 --set secrets.githubPrivateKey=private --set secrets.anthropicApiKey=anthropic
  • actionlint .github/workflows/diffscope.yml .github/workflows/eval.yml
  • sh -n install.sh
  • git diff --check

Notes

  • The Vite bundle warning remains: the main JS chunk is still over 500 kB. This PR preserves that as a visible warning rather than hiding it.
  • The local pre-push hook needs Python 3.11+ for tomllib; I pushed with /opt/homebrew/bin first in PATH so the hook used Python 3.12.

@haasonsaas haasonsaas marked this pull request as ready for review May 18, 2026 02:21
@haasonsaas haasonsaas merged commit 0fea838 into main May 18, 2026
15 checks passed
@haasonsaas haasonsaas deleted the codex/diffscope-deep-improvements branch May 18, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant