[codex] Harden DiffScope review operations#101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The prior surface had a few production-risk gaps: the chart set
DIFFSCOPE_API_KEYbut notDIFFSCOPE_SERVER_API_KEY, context patterns could escape the intended base path, verifier evidence was rendered as ordinary prompt text, and eval gates could disappear when model secrets were absent. This makes those contracts explicit and test-backed.Validation
cargo test(1565 passed)cargo clippy --all-targets -- -D warningscargo fmt -- --checknpm run buildnpm test(77 passed, 5 skipped)npm audit(0 vulnerabilities)helm lint charts/diffscopehelm template diffscope charts/diffscope --set secrets.serverApiKey=server --set secrets.githubWebhookSecret=hook --set secrets.githubAppId=123 --set secrets.githubPrivateKey=private --set secrets.anthropicApiKey=anthropicactionlint .github/workflows/diffscope.yml .github/workflows/eval.ymlsh -n install.shgit diff --checkNotes
tomllib; I pushed with/opt/homebrew/binfirst inPATHso the hook used Python 3.12.