fix: omit non-terminal runtime promotion writes#421
Conversation
PR SummaryMedium Risk Overview Adjusts promotion shaping by not projecting Reviewed by Cursor Bugbot for commit 913d84c. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
This PR changes mirrored Maestro source files in the public repo, but it does not link the matching private source-of-truth PR. Add one of these to the PR body, then re-run the check:
Mirrored files touched:
|
2ca0ce7 to
95f4fd6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95f4fd6d4b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
95f4fd6 to
3d7a148
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 913d84c2e9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (kind === "wait") { | ||
| return "AGENT_RUN_WAIT_TYPE_APPROVAL"; | ||
| } |
There was a problem hiding this comment.
Preserve wait_run emission for pending governance entries
This change removes waitType for all governance entries, so a policy.decision that maps to status: "pending" (which becomes ledger state waiting) will no longer generate a wait_run operation. That drops the only operation carrying approval-wait semantics (waitType) for those trajectories, so downstream runtime promotion can no longer represent the run as actively waiting for approval even though the ledger step/work item is waiting.
Useful? React with 👍 / 👎.
Summary
Verification
Follow-up to #419 and mirror for evalops/maestro-internal#1974.