You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Adjusts how runtime ledger entries are promoted into Platform run steps/waits, which can change downstream state/visibility for runs with failed events or sparse wait metadata. Changes are small and covered by targeted regression tests, but affect promotion semantics.
Overview
Refines AgentRuntime ledger promotion semantics to avoid over-promoting failures and to keep waits represented.
Error step classification is narrowed so only failed tool_result entries promote as AGENT_RUN_STEP_KIND_ERROR, while failed model_call entries remain AGENT_RUN_STEP_KIND_MODEL_CALL. Wait type derivation is hardened to preserve input vs approval when request metadata exists and to default unknown/metadata-poor waits to AGENT_RUN_WAIT_TYPE_APPROVAL so a wait_run promotion operation is still emitted.
Adds focused CLI regression tests covering the approval fallback for unknown waits and the revised failure classification for tool results vs model calls.
Reviewed by Cursor Bugbot for commit 943daa8. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #422 for review feedback that landed after the merge.
Changes:
Mirrors evalops/maestro-internal#1974.
Verification: