Skip to content

chore: sync public mirror from internal #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haasonsaas merged 2 commits into from
Jun 1, 2026
+20 −5
Merged

chore: sync public mirror from internal #735

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
012fdc9
chore: sync public mirror from internal
github-actions[bot] Jun 1, 2026
a392781
Merge branch 'main' into sync/public-release-mirror
haasonsaas Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions test/auth/totp.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,17 @@ vi.mock("../../src/db/client.js", () => ({
}));

describe("TOTP Service", () => {
async function findInvalidTotpCode(secret: string): Promise<string> {
for (let i = 0; i < 10; i++) {
const code = `${i}`.repeat(6);
const result = await verifyTotpCode(`invalid-probe-${i}`, secret, code);
if (!result.valid) {
return code;
}
}
throw new Error("Could not find an invalid TOTP code");
}

beforeEach(() => {
_resetRateLimitsForTesting();
});
Expand Down Expand Up @@ -81,8 +92,9 @@ describe("TOTP Service", () => {

it("should reject invalid code", async () => {
const secret = generateTotpSecret();
const invalidTotpCode = await findInvalidTotpCode(secret);

const result = await verifyTotpCode("user-1", secret, "000000");
const result = await verifyTotpCode("user-1", secret, invalidTotpCode);
expect(result.valid).toBe(false);
expect(result.error).toBe("invalid_code");
});
Expand All @@ -95,10 +107,11 @@ describe("TOTP Service", () => {

it("should rate limit after too many failures", async () => {
const secret = generateTotpSecret();
const invalidTotpCode = await findInvalidTotpCode(secret);

// Make 5 failed attempts
for (let i = 0; i < 5; i++) {
await verifyTotpCode("user-2", secret, "000000");
await verifyTotpCode("user-2", secret, invalidTotpCode);
}

const status = isRateLimited("user-2");
Expand All @@ -108,10 +121,11 @@ describe("TOTP Service", () => {

it("should return rate_limited error when limited", async () => {
const secret = generateTotpSecret();
const invalidTotpCode = await findInvalidTotpCode(secret);

// Exhaust attempts
for (let i = 0; i < 5; i++) {
await verifyTotpCode("user-3", secret, "000000");
await verifyTotpCode("user-3", secret, invalidTotpCode);
}

const result = await verifyTotpCode("user-3", secret, "123456");
Expand All @@ -122,10 +136,11 @@ describe("TOTP Service", () => {

it("should clear rate limit on success", async () => {
const secret = generateTotpSecret();
const invalidTotpCode = await findInvalidTotpCode(secret);

// Make some failures
await verifyTotpCode("user-4", secret, "000000");
await verifyTotpCode("user-4", secret, "000000");
await verifyTotpCode("user-4", secret, invalidTotpCode);
await verifyTotpCode("user-4", secret, invalidTotpCode);

// Succeed
const code = generateTotpCode(secret);
Expand Down
Loading