Skip to content

[proto] add evaluation completed event contract#25

Merged
haasonsaas merged 1 commit intomainfrom
codex/eval-signal-cloudevent
Apr 13, 2026
Merged

[proto] add evaluation completed event contract#25
haasonsaas merged 1 commit intomainfrom
codex/eval-signal-cloudevent

Conversation

@haasonsaas
Copy link
Copy Markdown
Contributor

Summary

  • add a typed events.v1.EvaluationCompleted payload for canonical evaluation.completed bus events
  • add a canonical CloudEvent fixture for the fermata -> pipeline technical capability seam
  • expose fixture/helper/package support so downstream repos can pin consumer tests to the shared contract

Testing

  • buf lint
  • buf generate
  • buf breaking --against ".git#branch=main"
  • go test ./...
  • npm run check:package

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 13, 2026

PR Summary

Medium Risk
Adds a new cross-service events.v1.EvaluationCompleted schema and wires it into helpers/fixtures and the published TS package surface, which could impact downstream consumers that rely on event contract stability. Changes are additive but touch shared event envelope tooling and contract tests.

Overview
Introduces a new typed bus payload, events/v1.EvaluationCompleted, for canonical evaluation.completed CloudEvents, with generated Go/TS code committed.

Adds a canonical protojson CloudEvent fixture for the Fermata → Pipeline seam and validates it via new contract tests, plus exposes it through contractfixtures with a new LoadEvaluationCompletedFixture helper.

Extends eventhelpers with UnpackEvaluationCompleted, updates documentation to reference the new helper/fixture, and updates package.json exports and the check:package script to include the new TS module.

Reviewed by Cursor Bugbot for commit 354ab6f. Bugbot is set up for automated code reviews on this repo. Configure here.

@haasonsaas haasonsaas merged commit 432def8 into main Apr 13, 2026
8 checks passed
@haasonsaas haasonsaas deleted the codex/eval-signal-cloudevent branch April 13, 2026 12:06
haasonsaas added a commit that referenced this pull request Apr 14, 2026
[proto] add evaluation completed event contract
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant