approvals/v1: add auto-approve policy fields#53
Conversation
PR SummaryMedium Risk Overview Extends Regenerates Go/Python/TypeScript protobuf outputs to reflect the updated schema. Reviewed by Cursor Bugbot for commit 9fc6bc2. Bugbot is set up for automated code reviews on this repo. Configure here. |
Review: overlap with #56This PR and #56 both address #55 (auto-approve fields). They touch identical files and will conflict. Key design differences: Auto-approve config modeling
Recommendation: prefer #56's approach
Suggest closing this PR in favor of #56, which also adds |
|
Closing in favor of #56, which covers the same scope with a stronger design: nested AutoApproveConfig message (cleaner nil-check, independently passable), DECISION_TYPE_AUTO_APPROVED enum value (critical for downstream switch exhaustiveness), and AutoApproveEvidence message (proper audit trail). Both PRs add approved_count to ApprovalHabit. Field numbers conflict, so only one can merge. |
Summary
Testing