Skip to content

Fix release smoke and startup default export#137

Merged
haasonsaas merged 1 commit intomainfrom
codex/fix-release-smoke-startup-default
Apr 20, 2026
Merged

Fix release smoke and startup default export#137
haasonsaas merged 1 commit intomainfrom
codex/fix-release-smoke-startup-default

Conversation

@haasonsaas
Copy link
Copy Markdown
Contributor

Summary

  • export startup.DefaultShutdownTimeout for public consumers mirrored out of platform
  • keep release smoke module caches outside the temporary module root
  • run go mod tidy before the clean-cache smoke build and make cleanup tolerate read-only module cache files

Test Plan

  • go test ./startup
  • go test ./...
  • actionlint .github/workflows/release.yml
  • git diff --check
  • local clean-cache smoke with github.com/evalops/service-runtime@v0.1.49 importing natsbus

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 20, 2026

PR Summary

Low Risk
Low risk: CI smoke-test workflow tweaks and a small exported constant with a simple unit test; no runtime logic changes beyond build/release automation.

Overview
Fixes the release workflow’s clean-cache smoke test by isolating the temp module workdir from GOMODCACHE/GOCACHE, running go mod tidy before go build, and making temp cleanup tolerate read-only cache files.

Exports startup.DefaultShutdownTimeout (10s) for consumers and adds a unit test to lock in the default value.

Reviewed by Cursor Bugbot for commit 3170641. Bugbot is set up for automated code reviews on this repo. Configure here.

@haasonsaas haasonsaas merged commit 9f8c851 into main Apr 20, 2026
7 checks passed
@haasonsaas haasonsaas deleted the codex/fix-release-smoke-startup-default branch April 20, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant