Fix recent changes defect #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The serverInstructions feature was using the old '-' separator to construct namespaced tool names, while the rest of the codebase has been updated to use '__' as the separator (via the common.create_namespaced_name function). Changes: - Updated _format_server_instructions in mcp_agent.py to use create_namespaced_name - Updated docstring in mcp_aggregator.py to reflect new naming convention - Updated integration tests to expect new __ separator in tool names This ensures consistency across the codebase for tool namespacing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serverInstructions feature was using the old '-' separator to construct namespaced tool names, while the rest of the codebase has been updated to use '__' as the separator (via the common.create_namespaced_name function).
Changes:
This ensures consistency across the codebase for tool namespacing.