fix: Prevent display freeze during tool call streaming #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed buffer management in StreamingMessageHandle._render_current_buffer() that was causing the display to freeze when streaming tool arguments. Changes: - Consolidate buffer without truncating content when > 10 items - Separate display_text from buffer storage to preserve full content - Remove problematic buffer resets that stored truncated content - Improve error handling with proper logging instead of silent pass The issue occurred when tool arguments streamed rapidly from providers like OpenAI. The buffer would exceed 10 items, trigger truncation, and reset to truncated content. Subsequent chunks would append to incomplete data, causing the display to appear frozen. All existing tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed buffer management in StreamingMessageHandle._render_current_buffer() that was causing the display to freeze when streaming tool arguments.
Changes:
The issue occurred when tool arguments streamed rapidly from providers like OpenAI. The buffer would exceed 10 items, trigger truncation, and reset to truncated content. Subsequent chunks would append to incomplete data, causing the display to appear frozen.
All existing tests pass.