Handle overlapping ACP prompt requests gracefully #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements elegant handling of overlapping prompt requests per ACP protocol: - Added `_active_prompts` set to track sessions with in-flight prompts - Detects when a second prompt arrives for a session with an active prompt - Immediately returns PromptResponse(stopReason="refusal") for overlapping requests - Uses try/finally to ensure session is always removed from active set - Added comprehensive test coverage for overlapping request scenarios Per ACP protocol spec: "Once a prompt turn completes, the Client may send another session/prompt..." - prompts must be sequential per session. This change prevents race conditions and ensures compliance with the protocol requirement. Addresses the ACP protocol requirement that only one prompt can be active per session at a time. If concurrent execution is needed, clients should use multiple sessions.
The previous test had a timing issue - it assumed the first prompt would still be active after 0.1s sleep, but the passthrough model completes too quickly. New approach: - Send both prompts truly concurrently (no sleep between them) - Don't assume which arrives first due to async scheduling - Verify that exactly one succeeds and one is refused - Confirm subsequent prompts work after both complete This makes the test more robust and accurately tests the overlap detection logic regardless of model execution speed.
evalstate
deleted the
claude/acp-overlapping-requests-011CUxyLzM3jq96EGjgwSio3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements elegant handling of overlapping prompt requests per ACP protocol:
_active_promptsset to track sessions with in-flight promptsPer ACP protocol spec: "Once a prompt turn completes, the Client may send another session/prompt..." - prompts must be sequential per session. This change prevents race conditions and ensures compliance with the protocol requirement.
Addresses the ACP protocol requirement that only one prompt can be active per session at a time. If concurrent execution is needed, clients should use multiple sessions.