Add HTTPS support through configuration options#34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14
This PR adds the ability to configure the web server to use HTTPS instead of HTTP.
This adds three new (internal) configuration directives,
httpsEnabled,httpsCertFileandhttpsKeyFile. The last two respectively contain the path to the certificate file and the path to the key file. If both of these have been passed, thehttpsEnableddirective will be set to true, which causes the web server to serve things over HTTPS instead of HTTP.The certificate and key file directives can be set through environment variables (
GOBBLE_HTTPS_CERT_FILEandGOBBLE_HTTPS_KEY_FILE) and command-line flags (-https-cert-fileand-https-key-file).When both of these are passed, HTTPS will be enabled.
This also has effect on the default listening address. If not specified, the default listening address will be port 443 on all interfaces if HTTPS is enabled, and port 80 on all interfaces if HTTPS is not enabled.