Initial commit: Login UI #2
Conversation
andreaowu
requested review from
AlejandroSparza77,
andreaowu,
delier-sps,
emma-mao and
evanlin-dev
| @Override | ||
| public void doPost(HttpServletRequest request, HttpServletResponse response) throws IOException { | ||
| // Get the value entered in the form. | ||
| String clientName = request.getParameter("clientName"); |
There was a problem hiding this comment.
Since clientName and clientPassword are used a few times in this class you can make them static variables. This makes a single copy of the strings and also protects against any potential typos in future uses.
| KeyFactory keyFactory = datastore.newKeyFactory().setKind("Task"); | ||
|
|
||
| // Print the value so you can see it in the server logs. | ||
| System.out.println(clientName + ": " + clientPassword); |
There was a problem hiding this comment.
I'm not sure what the requirements are for this but we may want to reconsider the safety implications of printing the password.
|
|
||
| public Task(long id, String names, String lastNames, String username, | ||
| long timestamp) { | ||
|
|
There was a problem hiding this comment.
Style nit: You can get rid of this empty extra line.
| } | ||
|
|
||
| public String getUsername() { | ||
|
|
There was a problem hiding this comment.
Style nit: You can get rid of this empty extra line.
|
|
||
| // check if the username exists in the database | ||
| boolean existUsername = true; | ||
| for (int i = 0; i < tasks.size(); i++){ |
There was a problem hiding this comment.
Note that you can make this more efficient by storing a set or map of usernames and then checking if the username exists there. It would be O(1) runtime instead of O(n) (please reach out if you have further questions about this!)
No description provided.