Be resilient against readFileSync failures

[isaacs]

Generating a call stack when using this library can trigger a call to
fs.readFileSync. That call can sometimes fail, resulting in a very
confusing stack trace (or none at all, which is even more confusing).

This patch wraps calls to fs.readFileSync() in a try/catch. If the read
fails, then the file contents are omitted, but this is far better than
total failure.

Tracking down this one was fun, as you can probably imagine :)

[LinusU]

Tracking down this one was fun, as you can probably imagine :)

Hehe, sorry 🙈

Thanks for the patch!

[LinusU]

Released as 0.4.18 🎉

[isaacs]

Thanks for the swift release!

It's kind of an interesting story, really, and nothing to apologize for. I found this while writing unit tests for a module that reads files, so I was triggering fs.read errors (by monkey-patching) in order to exercise the error handling code. But when tap went to print the error, this module got called to update the error stack before I could un-monkeypatch fs.read, resulting in a really deep yak shave. console.trace was also affected, so when I added that to try to figure out what was calling into it, it printed out [object Object].

Fun things happen when you write tests that intentionally break random things :)

[LinusU]

Haha, that is amazing 😄