Skip to content

Fix multiple discounts delete on eb #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BiancaSozzi merged 1 commit into from
Nov 15, 2018
Merged

Fix multiple discounts delete on eb #119

BiancaSozzi merged 1 commit into from
Nov 15, 2018

Conversation

@francobett
Copy link
Contributor

@francobett francobett commented Nov 15, 2018 •
edited
Loading

  • Fix when the discount it has multiple discounts related on EB, so now if i delete it, it will delete all the discounts on EB

BiancaSozzi
BiancaSozzi approved these changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@BiancaSozzi BiancaSozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@BiancaSozzi BiancaSozzi merged commit ce835a0 into master Nov 15, 2018
@coveralls
Copy link

coveralls commented Nov 15, 2018

Pull Request Test Coverage Report for Build 450

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 97.718%
Totals Coverage Status
Change from base Build 448: 0.005%
Covered Lines: 985
Relevant Lines: 1008
💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 15, 2018

Pull Request Test Coverage Report for Build 379

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 97.718%
Totals Coverage Status
Change from base Build 448: 0.005%
Covered Lines: 985
Relevant Lines: 1008
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BiancaSozzi BiancaSozzi BiancaSozzi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@francobett @coveralls @BiancaSozzi