Skip to content

select discount tested & discount access mixin #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Zhinon merged 1 commit into from
Oct 4, 2018
Merged

select discount tested & discount access mixin #39

Zhinon merged 1 commit into from
Oct 4, 2018

Conversation

@francobett
Copy link
Contributor

@francobett francobett commented Oct 4, 2018 •
edited
Loading

  1. Select Discount View Tested
    • Post test remaining
  2. Discount access mixin : Deny access to not owned discounts
  3. Fix http 40X

@coveralls
Copy link

coveralls commented Oct 4, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 60

  • 21 of 25 (84.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.6%) to 85.467%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bundesliga_app/views.py 10 11 90.91%
bundesliga_app/utils.py 7 10 70.0%
Totals Coverage Status
Change from base Build 57: 3.6%
Covered Lines: 247
Relevant Lines: 289
💛 - Coveralls

Zhinon
Zhinon reviewed Oct 4, 2018
View reviewed changes
bundesliga_app/views.py
def get_context_data(self, **kwargs):
context = super(ManageDiscount, self).get_context_data(**kwargs)
context['event'] = self.get_event()
# import ipdb;ipdb.set_trace()
Copy link
Contributor

@Zhinon Zhinon Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you gotta be kidding me!

Zhinon
Zhinon approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@Zhinon Zhinon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

bundesliga_site/settings.py

# SECURITY WARNING: don't run with debug turned on in production!
DEBUG = True
DEBUG = False
Copy link
Contributor

@Zhinon Zhinon Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Zhinon Zhinon merged commit a11f103 into master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zhinon Zhinon Zhinon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@francobett @coveralls @Zhinon