Add timestamp to InstallmentCondition and refactor tests #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francob-eb
approved these changes
Oct 9, 2019
| } | ||
| contract = Contract(**contract_data) | ||
| contract.save() | ||
| contract = Contract.objects.create(**contract_data) |
There was a problem hiding this comment.
Have you consider using factory_boy? It will simplify all your tests, you can create django models objects easily. Usage:
Creating factories: https://github.com/evbeda/imahunga/blob/master/bundesliga_app/factories.py
Using factories in tests: https://github.com/evbeda/imahunga/blob/master/bundesliga_app/tests.py#L256-L271
walterbucolo-eb
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow the user to check when did she mark conditions as done, the InstallmentCondition model had to be refactored.
This involved changing the "done" field from a BooleanField to a DateTimeField, which is initially null and stores a timestamp when the user marks it as done.
Also freezegun was installed to patch datetime.now when testing this.