Skip to content

Conversation

@juanelias-eb
Copy link
Collaborator

@juanelias-eb juanelias-eb commented Oct 29, 2019

The download_csv view was removed and its implementation was moved to InstallmentsView.
Tests were refactored to improve readability.

Export to CSV's href is now modified via javascript to add the download uri param

Copy link

@francob-eb francob-eb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juanelias-eb juanelias-eb merged commit 9a5fce2 into master Oct 30, 2019
@juanelias-eb juanelias-eb deleted the csv_naming branch October 30, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants