Add Solinteg Modbus TCP meter template#29543
Merged
andig merged 1 commit intoevcc-io:masterfrom May 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider making the Modbus
idandportconfigurable parameters (with sensible defaults of 255 and 502) instead of hardcoding them in themodbuspreset, to accommodate installations that use different TCP settings.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider making the Modbus `id` and `port` configurable parameters (with sensible defaults of 255 and 502) instead of hardcoding them in the `modbus` preset, to accommodate installations that use different TCP settings.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
These values are already configurable through evcc's Modbus template parameter expansion. The Users can still override them, for example: meters:
- name: battery
type: template
template: solinteg
usage: battery
modbus: tcpip
host: 192.168.1.129
port: 1502
id: 1 |
Member
|
Is the delay really needed? |
496682f to
c3c3caf
Compare
Contributor
Author
|
Good point. The 'delay' parameter was inherited from the Wattsonic template, but it is not needed for Solinteg TCP template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a dedicated Solinteg Modbus TCP meter template.
Solinteg inverters are currently grouped under the existing Wattsonic template, but that template is configured for RS485-style defaults. In my setup, Solinteg over Modbus TCP requires Modbus ID
255, and the battery registers differ from the existing Wattsonic template.This PR adds a separate
solintegtemplate so the TCP configuration can work without changing the existing Wattsonic/RS485 behavior.Tested locally
Tested with evcc
0.306.0using Modbus TCP against a Solinteg inverter at port502.Working registers:
11000, holding,int32, scale-111028, holding,uint3230258, holding,int3233000, holding,uint16, scale0.0152503, holding write,uint16, scale10Notes
The existing Wattsonic template is left unchanged to avoid affecting RS485 users.