Skip to content

Wallbe: remove deprecated (BC)#29647

Merged
andig merged 3 commits intomasterfrom
remove/wallbe
May 5, 2026
Merged

Wallbe: remove deprecated (BC)#29647
andig merged 3 commits intomasterfrom
remove/wallbe

Conversation

@andig
Copy link
Copy Markdown
Member

@andig andig commented May 5, 2026

It has been deprecated for ~2 years and caused confusion in a recent PR. Replaced by advanced phoenix-ev-eth.

@andig andig added the devices Specific device support label May 5, 2026
@andig andig requested a review from premultiply May 5, 2026 06:51
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig andig changed the title Wallbe: remove (BC) Wallbe: remove deprecated (BC) May 5, 2026
@premultiply
Copy link
Copy Markdown
Member

Should we add covers to phoenix-ev-eth template?

@andig
Copy link
Copy Markdown
Member Author

andig commented May 5, 2026

Würde das als 1:1 drop-in funktionieren? Könntest Du das evtl. kurz testen?

@andig
Copy link
Copy Markdown
Member Author

andig commented May 5, 2026

@copilot resolve the merge conflicts in this pull request

Copilot AI and others added 2 commits May 5, 2026 20:08
…flicts

Co-authored-by: andig <184815+andig@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 5, 2026

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in 2cb3b83. The conflicts were in wallbe-meter.yaml and wallbe-pre2019-meter.yaml — master had added capabilities: ["meter"] to those files, but our branch deletes them entirely. Kept our deletion since the whole point of this PR is to remove wallbe.

Also added covers: ["wallbe", "wallbe-meter", "wallbe-pre2019", "wallbe-pre2019-meter"] to phoenix-ev-eth (2c67baa) to address @premultiply's suggestion for backward compatibility.

Should we add covers to phoenix-ev-eth template?

Added in 2c67baa: covers: ["wallbe", "wallbe-meter", "wallbe-pre2019", "wallbe-pre2019-meter"] to the phoenix-ev-eth template.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 192.168.1.1
    • Triggering command: /tmp/go-build1178244789/b1494/service.test /tmp/go-build1178244789/b1494/service.test -test.testlogfile=/tmp/go-build1178244789/b1494/testlog.txt -test.paniconexit0 -test.timeout=10m0s estl�� om/andig/gosunsp-errorsas mpile ux-amd64/pkg/tool/linux_amd64/vet -errorsas -ifaceassert mpile ux-amd64/pkg/too-buildtags -ato�� r/shoutrrr@v0.14-errorsas r/shoutrrr@v0.14-ifaceassert ux-amd64/pkg/tool/linux_amd64/compile -errorsas /gosunspec/model-o mpile ux-amd64/pkg/too-trimpath (packet block)
    • Triggering command: /tmp/go-build2502069032/b1495/service.test /tmp/go-build2502069032/b1495/service.test -test.testlogfile=/tmp/go-build2502069032/b1495/testlog.txt -test.paniconexit0 -test.timeout=10m0s swit�� g_.a 2069032/b170/ ux-amd64/pkg/tool/linux_amd64/compile -ldflags=&#34;-O2&#34; &#34;/usr/bin/ld tion.go mpile ux-amd64/pkg/too-plugin-opt=/usr/libexec/gcc/x86_64-linux-gnu/13/lto-wrapper -I rwall@v0.3.0/0_d-plugin-opt=-pass-through=-lgcc rwall@v0.3.0/aut-plugin-opt=-pass-through=-lgcc_s ux-amd64/pkg/tool/linux_amd64/vet -pthread -Wl,--no-gc-sect-quiet t ux-amd64/pkg/toox86_64-linux-gnu (packet block)
  • 224.0.0.251
    • Triggering command: REDACTED, pid is -1 (packet block)
  • api.awattar.at
    • Triggering command: /tmp/go-build1178244789/b1446/tariff.test /tmp/go-build1178244789/b1446/tariff.test -test.testlogfile=/tmp/go-build1178244789/b1446/testlog.txt -test.paniconexit0 -test.timeout=10m0s -ato�� /v2@v2.14.0/api/-errorsas t ux-amd64/pkg/tool/linux_amd64/vet -errorsas pto/hkdf mpile ux-amd64/pkg/too-buildtags -ato�� 0/term.go 0/term_unix.go ux-amd64/pkg/tool/linux_amd64/vet -errorsas /gosunspec/model-test.testlogfile=/tmp/go-build1178244789/b1356/testlog.txt mpile ux-amd64/pkg/too-test.timeout=10m0s (dns block)
    • Triggering command: /tmp/go-build131724975/b1446/tariff.test /tmp/go-build131724975/b1446/tariff.test -test.testlogfile=/tmp/go-build131724975/b1446/testlog.txt -test.paniconexit0 -test.timeout=10m0s -goversion go1.26.0 -c=4 -nolocalimports -importcfg /tmp/go-build1178244789/b1484/importcfg -pack /tmp/go-build1178244789/b1484/_testmain.go -ato�� o-v2/service/sso-errorsas mpile 0.1-go1.26.0.lin-nilfunc -errorsas rr/pkg/services/-o t 0.1-go1.26.0.lin-importcfg (dns block)
    • Triggering command: /tmp/go-build2502069032/b1447/tariff.test /tmp/go-build2502069032/b1447/tariff.test -test.testlogfile=/tmp/go-build2502069032/b1447/testlog.txt -test.paniconexit0 -test.timeout=10m0s 2069�� om/d2r2/go-i2c@v0.0.0-2019112318-c=4 -I rg/toolchain@v0.0.1-go1.26.0.lin-importcfg --gdwarf-5 --64 -o evjrFE8/5-663Lm--buildtags estl�� o /tmp/go-build250-ifaceassert 0.1-go1.26.0.lin-nilfunc . io/evcc/plugin/m--64 t 0.1-go1.26.0.lin/tmp/cc1e68DB.o (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot finished work on behalf of andig May 5, 2026 20:17
@andig andig merged commit 3a99f7d into master May 5, 2026
7 checks passed
@andig andig deleted the remove/wallbe branch May 5, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devices Specific device support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants