EEBus: drop redundant Scenario middle word from constant names

[andig]

Summary

Follow-up to #29701. Constant names like MGCPScenarioPower and EVCEMScenarioPowerPerPhase repeat the word Scenario even though every constant in this package is a scenario number. Drop the middle word so call sites read more naturally:

• eebus.MGCPScenarioPower → eebus.MGCPPower
• eebus.MPCScenarioCurrentPerPhase → eebus.MPCCurrentPerPhase
• eebus.LPCScenarioLimit → eebus.LPCLimit
• eebus.EVCEMScenarioPowerPerPhase → eebus.EVCEMPowerPerPhase
• …etc for LPP, OPEV, OSCEV, EVSOC

The use-case prefix (MGCP, MPC, LPC, LPP, OPEV, OSCEV, EVCEM, EVSOC) keeps the namespace clear; the trailing word names the quantity. Scenario adds nothing because the type and the comment already say so.

No behavior change.

Test plan

• go build ./charger/... ./meter/... ./server/eebus/... passes
• go test ./charger/... ./meter/... ./server/eebus/... passes
• gofmt -l clean

[sourcery-ai]

Hey - I've left some high level feedback:

• These renames change exported identifiers; if this package is consumed externally you may want to keep the old *Scenario* constants as deprecated aliases for a release cycle to avoid breaking downstream users.
• Since all of these values represent scenario IDs, consider defining a dedicated type Scenario uint (or similar) and using it for the constants and relevant function signatures to improve type safety and self-documentation.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- These renames change exported identifiers; if this package is consumed externally you may want to keep the old `*Scenario*` constants as deprecated aliases for a release cycle to avoid breaking downstream users.
- Since all of these values represent scenario IDs, consider defining a dedicated `type Scenario uint` (or similar) and using it for the constants and relevant function signatures to improve type safety and self-documentation.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}